D21955: [copyjob] Only set modification time if the kio-slave provided it

David Faure noreply at phabricator.kde.org
Fri Jun 21 12:10:47 BST 2019


dfaure added inline comments.

INLINE COMMENTS

> copyjob.cpp:1709
>              moveJob->setSourceSize((*it).size);
> -            moveJob->setModificationTime((*it).mtime); // #55804
> +            if ((*it).mtime.toMSecsSinceEpoch() != 1000 * (-1)) {
> +                moveJob->setModificationTime((*it).mtime); // #55804

Wouldn't mtime.isNull() or mtime.isValid() be simpler?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D21955

To: wbauer, #frameworks, bruns, dfaure, ngraham
Cc: ngraham, kde-frameworks-devel, #dolphin, LeGast00n, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190621/7e549f1e/attachment.html>


More information about the Kde-frameworks-devel mailing list