D21923: Replace old kconfig_compiler_kf5 references to kconfig_compiler

Méven Car noreply at phabricator.kde.org
Thu Jun 20 13:57:39 BST 2019


meven added a comment.


  In D21923#482383 <https://phabricator.kde.org/D21923#482383>, @apol wrote:
  
  > That doesn't look alright:
  >  https://phabricator.kde.org/source/kconfig/browse/master/src/kconfig_compiler/kconfig_compiler.cpp$1768
  
  
  That is a line I am editing in this patch precissely.
  The line is about generated code only, the bulk of the patch is then updating tests.
  
  > We are still including the _kf5 postfix.
  > 
  > Also note the executable still is called kconfig_compiler_kf5
  
  Since 892e693f616297a91835d3d79353926b96bd1201 <https://phabricator.kde.org/R237:892e693f616297a91835d3d79353926b96bd1201> and the pointed review, kconfig_compiler is the main executable name used (see KF5ConfigMacros.cmake) for future proofing reason mainly (avoiding to update the executable name for kf6 for instance).
  kconfig_compiler_kf5 is kept for backward compatibility with kde4support only.
  
  And for instance on my system (kubuntu) kconfig_compiler_kf5 is not installed, while kconfig_compiler is.
  The leftover mention of kconfig_compiler_kf5 in generated files is confusing consequently.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D21923

To: meven, dfaure, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190620/7cbdc5ab/attachment.html>


More information about the Kde-frameworks-devel mailing list