D21894: set the focusPolicy of kpasswordlineedit to the policy of its proxy
Harald Sitter
noreply at phabricator.kde.org
Wed Jun 19 10:23:56 BST 2019
sitter created this revision.
sitter added a reviewer: cfeck.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
this is entirely the same kind of change as done in
c695aa5a21a731ab72c8405141b43feccad2b56a <https://phabricator.kde.org/R236:c695aa5a21a731ab72c8405141b43feccad2b56a>
a proxy does not automatically adopt the same focus policy as the widget
it proxies. instead it has its own policy which is simply the qwidget
default.
this prevents keyboard focus from working in (e.g.) buddy scenarios as well
as when hitting Tab to move through the intractable widgets with a
keyboard.
seeing as kpasswordlineedit is essentially a lineedit and being able to
"tab" from a username edit to a password edit seems a crucial behavioral
expectation.
BUG: 398275
CHANGELOG: KPasswordLineEdit now correctly inherits its QLineEdit's focusPolicy
TEST PLAN
designer reports StrongFocus as default now. when using the KPLE without changing its policy it will correctly receive focus through keyboard tabbing
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21894
AFFECTED FILES
src/kpasswordlineedit.cpp
To: sitter, cfeck
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190619/84fb75c3/attachment.html>
More information about the Kde-frameworks-devel
mailing list