D21839: [TermGenerator] Use UTF-8 ByteArray for termList

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sun Jun 16 23:42:30 BST 2019


bruns added a comment.


  In D21839#480777 <https://phabricator.kde.org/D21839#480777>, @poboiko wrote:
  
  > > As the limit is somewhat arbitrary, maybe we can just limit the QString? I don't think this has any serious side effects.
  >
  > Yep, that's what I've suggested (if I understood you correctly).
  >  I guess, we can put the trimming part right to `termList()`, it will further reduce code repetition. Something like
  >
  >   str = str.left(maxTermSize); 
  >   list << str.toUtf8();
  >
  
  
  See D21865 <https://phabricator.kde.org/D21865>

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21839

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190616/8c44abd7/attachment.html>


More information about the Kde-frameworks-devel mailing list