D21661: add snoretoast backend for KNotifications on Windows

Hannah von Reth noreply at phabricator.kde.org
Sat Jun 15 11:15:07 BST 2019


vonreth added inline comments.

INLINE COMMENTS

> notifybysnore.cpp:72
> +        sock->deleteLater();
> +        sock->close();
> +        const QString data =

deleteLater should also close the socket.
Also don't use a pointer after you deleted it, even with a deleteLater.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190615/8566e190/attachment.html>


More information about the Kde-frameworks-devel mailing list