D21788: Make Plasma::Svg::elementRect a bit leaner

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> bruns wrote in svg.cpp:123
> Are you sure about this? As far as I can see:
> 
> `QRegularExpression::QRegularExpression(QString pattern)` default constructs a `QRegularExpressionPrivate`, which sets `dirty(true)`.
> 
> Calling `QRE::globalMatch()` calls `QREPrivate::compilePattern`, which calls `pcre2_compile_16` and `pcre2_jit_compile_16`.
> 
> https://code.woboq.org/qt5/qtbase/src/corelib/tools/qregularexpression.cpp.html#_ZN25QRegularExpressionPrivate14compilePatternEv
> 
> I don't see any caching here.

pcre2 does it, AFAIK.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21788

To: apol, #plasma, #frameworks
Cc: bruns, kde-frameworks-devel, LeGast00n, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190614/1ded852f/attachment.html>