D17816: Support for xattrs on kio copy/move

[Stefan Brüns]

bruns added a comment.


  There are several comments not addressed yet ...

INLINE COMMENTS

> copyxattrjob.cpp:125
> +    m_keyList.removeLast(); // the last item is alwys empty
> +    for (const auto & key : m_keyList) {
> +        // get the size of key value

`qAsConst(m_keyList)`

> copyxattrjob.cpp:130
> +#elif defined(Q_OS_MAC)
> +        ssize_t valuelen = listxattr(m_bsrc, key.constData(), nullptr, 0, 0, 0);
> +#elif HAVE_SYS_EXTATTR

`listxattr` is wrong here ...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: cochise, dfaure, chinmoyr, bruns, #frameworks
Cc: cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190611/a4a7c692/attachment-0001.html>