D21721: [WIP] Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

Dan Leinir Turthra Jensen noreply at phabricator.kde.org
Mon Jun 10 14:11:33 BST 2019


leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Basic KNewStuffQuick dialog for testing purposes
  
  Actually return the number of comments, not the rating
  
  Change the install overwrite question to YesNo
  
  It was previously a very uninformative question, so rewording
  it to a YesNo question, with more verbosity, seems reasonable,
  given this is potentially destructive.
  
  Add a QuestionListener for KNewStuffQuick
  
  This was promised in the documentation already, and missing,
  which is a bit silly. Let's just implement that ;)
  
  Add the Question enums to its metaobject
  
  Expose method to get the row of a specific EntryInternal
  
  Add the QtQuick QuestionAsker component
  
  A component used to forward questions from KNewStuff's
  engine to the UI, similar to how the KNewStuff::WidgetQuestionListener
  class works.
  
  Slightly modified GridDelegate, to allow for a tile style view
  
  Based on the KCM GridDelegate
  
  Add the Ratings component from Discover
  
  Should this perhaps be in a more centrally usable location? Seems
  like something we'd probably want to be using in more locations,
  for a more consistent look when ratings are involved...
  
  Add a model exposing categories metadata to QtQuick
  
  A model to care for the comments for a single EntryInternal
  
  This is a step along the way to add comment support to KNewStuff
  
  Actually build the CommentsModel
  
  Implement support for Attica's comments support in KNSCore::Provider
  
  Add some getters to KNSCore::Engine (name, search fields, and comments)
  
  Expose the various new functionality in KNSCore::Engine
  
  This includes the name, categories, and filter and sort options
  
  Add Comments, adoption and full installation support to Quick ItemsModel
  
  Actually build and expose our various new classes in KNewStuffQuick
  
  Add a screenshots display component, based heavily on Discover's
  
  Very basic (for now) comment delegate
  
  A Kirigami.ScrollablePage for showing an entry's comments
  
  A Kirigami.OverlaySheet for picking a specific DownloadItem to install
  
  Add a component for viewing an Entry's details (KCM.SimpleKCM based)
  
  Add a DownloadDialog equivalent to KNewStuffQuick
  
  This page is partly based on design work found on:
  https://phabricator.kde.org/D20693#455565
  and partly on discussions with the VDG. The BigPreview delegate
  specifically was envisioned by Andy Betts
  
  Add the new components to the qmldir

REPOSITORY
  R304 KNewStuff

BRANCH
  knsquick-feature-parity-with-kns (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21721

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/CMakeLists.txt
  src/core/commentsmodel.cpp
  src/core/commentsmodel.h
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/installation.cpp
  src/core/itemsmodel.cpp
  src/core/itemsmodel.h
  src/core/provider.h
  src/core/question.h
  src/qtquick/CMakeLists.txt
  src/qtquick/categoriesmodel.cpp
  src/qtquick/categoriesmodel.h
  src/qtquick/qml/ConditionalLoader.qml
  src/qtquick/qml/EntryCommentDelegate.qml
  src/qtquick/qml/EntryCommentsPage.qml
  src/qtquick/qml/EntryScreenshots.qml
  src/qtquick/qml/GridTileDelegate.qml
  src/qtquick/qml/NewStuffDownloadItemsSheet.qml
  src/qtquick/qml/NewStuffEntryDetails.qml
  src/qtquick/qml/NewStuffPage.qml
  src/qtquick/qml/NewStuffQuestionAsker.qml
  src/qtquick/qml/Rating.qml
  src/qtquick/qml/Shadow.qml
  src/qtquick/qmldir
  src/qtquick/qmlplugin.cpp
  src/qtquick/quickengine.cpp
  src/qtquick/quickengine.h
  src/qtquick/quickitemsmodel.cpp
  src/qtquick/quickitemsmodel.h
  src/qtquick/quickquestionlistener.cpp
  src/qtquick/quickquestionlistener.h
  tests/CMakeLists.txt
  tests/khotnewstuff-dialog-ui/main.qml
  tests/khotnewstuff-dialog.cpp

To: leinir
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190610/34c9e852/attachment.html>


More information about the Kde-frameworks-devel mailing list