D21706: [ModifiedFileIndexer] Use correct mimetype for folders, delay until needed

Igor Poboiko noreply at phabricator.kde.org
Mon Jun 10 10:10:09 BST 2019


poboiko added inline comments.

INLINE COMMENTS

> modifiedfileindexer.cpp:68
>          QFileInfo fileInfo(filePath);
> -
> -        // A folders mtime is updated when a new file is added / removed / renamed
> -        // we don't really need to reindex a folder when that happens
> -        // In fact, we never need to reindex a folder
> -        if (timeInfo.mTime && fileInfo.isDir()) {
> +        if (fileInfo.isSymLink()) {
>              continue;

Does it also changes behavior of ModifiedFileIndexer? What happened to symlinks before?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D21706

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190610/3bef6f25/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list