D21708: [ModifiedFileIndexer] Avoid shadowing XAttr changes by content changes

Stefan BrĂ¼ns noreply at phabricator.kde.org
Mon Jun 10 00:04:07 BST 2019


bruns created this revision.
bruns added reviewers: Baloo, ngraham, astippich, poboiko.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The ModifiedFileIndexer updates the timestamps, which has the effect
  the XAttr indexer will not pick up any XAttr changes later when both
  happen at approximately the same time.
  
  In case the file metadata has changed, also update everything associated
  to the ctime (XAttrs, filename). This also has the nice side effect
  of getting rid of a separate BasicIndexingJob run later.

TEST PLAN
  1. touch testfile; sleep 10
  2. setfattr -n baloo.file.rating -v 4 ; touch testfile
  
  After the change, `balooshow testfile` shows the rating.

REPOSITORY
  R293 Baloo

BRANCH
  fix_races

REVISION DETAIL
  https://phabricator.kde.org/D21708

AFFECTED FILES
  src/file/modifiedfileindexer.cpp

To: bruns, #baloo, ngraham, astippich, poboiko
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190609/fd0b86dc/attachment.html>


More information about the Kde-frameworks-devel mailing list