D21661: add snoretoast backend for KNotifications on Windows

[Hannah von Reth]

vonreth added inline comments.

INLINE COMMENTS

> CMakeLists.txt:45
> +   set_package_properties(LibSnoreToast PROPERTIES TYPE REQUIRED
> +      PURPOSE     "Enable support for the snorenotify framework"
> +      DESCRIPTION "a cross-platform notification framework"

It's snoretoast not Snorenotify 😊 so you used the wrong description

> pino wrote in CMakeLists.txt:112
> this should be the `_FOUND` variable, just like done for the others

Hm I don't think the config sets a found variable. But

  if (TARGET Snoretoast::Snoretoast)

Actions should work.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190608/4d6ede79/attachment-0001.html>