D21661: add snoretoast backend for KNotifications on Windows

[Piyush Aggarwal]

brute4s99 marked 22 inline comments as done and an inline comment as not done.
brute4s99 added a comment.


  update incoming

INLINE COMMENTS

> pino wrote in CMakeLists.txt:48-49
> why are these two needed? if snoretoast require them, then its cmake config file must require them, so that the above `find_package(LibSnoreToast)` is enough

the interfacing plugin (notifybysnore) requires QLocalServer and QLocalSocket, which are from Qt5Network.
Qt5Core has QProcess, QDir, QTemporaryDir and a bunch of other headers, which are required for the plugin as well.

> pino wrote in knotificationmanager.cpp:76
> this does not seem related to snoretoast

yeah, looks like it picked up changes from commits on master. apologies for this.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190608/db2208c0/attachment.html>