D21584: Add LE Advertising and GATT APIs

[David Rosca]

drosca requested changes to this revision.
drosca added a comment.
This revision now requires changes to proceed.


  It seems you uploaded only diff with latest changes, you need to upload the entire diff against master.

INLINE COMMENTS

> gattapplication.h:47
>       */
> -    explicit GattApplication(QObject *parent = nullptr);
> +    explicit GattApplication(const QString &objectPathPrefix, QObject *parent = nullptr);
>  

Maybe it would be best to add constructor that uses default object path. Also please add better documentation as to what object path prefix is.

`explicit GattApplication(QObject *parent = nullptr);`

REVISION DETAIL
  https://phabricator.kde.org/D21584

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190606/f67ff75f/attachment-0001.html>