D21613: Format focal length as milli meter

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Jun 6 00:23:59 BST 2019


bruns added inline comments.

INLINE COMMENTS

> propertyinfotest.cpp:144
>          { Property::AspectRatio,            true,  1.77778,                 QStringLiteral("1.78:1")},
> +        { Property::PhotoFocalLength,       true,  2.0,                     QStringLiteral("2 mm")},
>      };

For small frame cameras (compact cameras, smartphones, ...) the real focal length is often in the range of only a few millimeters, please add a test case which checks e.g. "2.4 mm" is formatted as such.

REPOSITORY
  R286 KFileMetaData

BRANCH
  focal_length

REVISION DETAIL
  https://phabricator.kde.org/D21613

To: astippich, bruns, ngraham
Cc: kde-frameworks-devel, #baloo, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190605/6440f817/attachment.html>


More information about the Kde-frameworks-devel mailing list