D21579: [FilteredDirIterator] Avoid RegExp overhead for exact matches
    Igor Poboiko 
    noreply at phabricator.kde.org
       
    Tue Jun  4 18:37:46 BST 2019
    
    
  
poboiko added inline comments.
INLINE COMMENTS
> regexpcache.cpp:60
> +        }
>          f.replace(QLatin1Char('.'), QStringLiteral("\\."));
>          f.replace(QLatin1Char('?'), QLatin1Char('.'));
A quick note for future. There is `QRegularExpression::wildcardToRegularExpression()`, which apparently does precicely this.
It is there since Qt 5.12 though, while we depend on Qt 5.10. But Plasma already bumped dependency to 5.12, so so we can change it when Frameworks will follow this bump.
REPOSITORY
  R293 Baloo
BRANCH
  submit_unindexed
REVISION DETAIL
  https://phabricator.kde.org/D21579
To: bruns, #baloo, ngraham, astippich, poboiko, broulik
Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190604/928082e6/attachment-0001.html>
    
    
More information about the Kde-frameworks-devel
mailing list