D21459: Always save view settings when switching from one view mode to another

Nathaniel Graham noreply at phabricator.kde.org
Mon Jun 3 14:39:28 BST 2019


ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  If you're going to rename the functions because these actions no longer really toggle anything, I think we need to keep a verb in there. Suggest something like `_k_slotShowDetailsView` or `_k_slotSwitchToDetailsView`
  
  Otherwise LGTM in terms of code and behavior!

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21459

REVISION DETAIL
  https://phabricator.kde.org/D21459

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190603/46f5e45a/attachment.html>


More information about the Kde-frameworks-devel mailing list