D22836: Fix checking dirs for metainfo.yaml with non-ascii chars with Python 2.7

Albert Astals Cid noreply at phabricator.kde.org
Tue Jul 30 22:08:39 BST 2019


aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  Pino please take a step back and rethink your position.
  
  Yes, supporting Python2  sucks, but this is **2** lines of code while porting everything to Python 3 is lots of work more.
  
  If this gets us up and running while someone can do the Python 3 there's absolutely no reason not to commit this.
  
  @kossebau maybe add a TODO saying "remove this after pyhon 3 port"?
  
  Other than that if it's confirmed this makes something that is broken work, this should be commited.

REPOSITORY
  R264 KApiDox

BRANCH
  handlenonasciipathwpython27

REVISION DETAIL
  https://phabricator.kde.org/D22836

To: kossebau, ochurlaud, bshah, aacid
Cc: aacid, pino, kde-frameworks-devel, kde-doc-english, LeGast00n, sbergeron, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190730/e42a26e2/attachment.html>


More information about the Kde-frameworks-devel mailing list