D22061: Add a logging category for logs warnings

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> CMakeLists.txt:102
> +install(FILES kconf.categories  DESTINATION ${KDE_INSTALL_LOGGINGCATEGORIESDIR})
> +install(FILES kconf.categories  DESTINATION ${KDE_INSTALL_CONFDIR})

This line is not useful

> CMakeLists.txt:17
> +ecm_qt_declare_logging_category(libkconfigcore_SRCS
> +                                HEADER kconf_desktop_debug.h
> +                                IDENTIFIER KCONF_CORE_LOG

the framework is called kconfig, the public headers are called kconfig*.h, there's no reason to truncate the framework name.

Also, why 'deskop' in the name ? this is for kconfigcore. kconfigcore_debug.h sounds better

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D22061

To: meven, #frameworks, apol
Cc: cgiboudeaux, mikeroyal, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190730/859e3b3f/attachment.html>