D22786: KTar::openArchive: Don't assert if file has two root dirs

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Let's be tolerant and skip the second root dir (with a warning, but without return false). This would be more in line with what we do in case of duplicated subdirs, and with what `tar` does.
  
  Testcase:
  
    mkdir /tmp/tar
    touch /tmp/tar/file
    cd /tmp/tar
    tar cf /tmp/tar.tar.gz . .
    tar tf /tmp/tar.tar.gz
    ./
    ./file
    ./tar.tar.gz
    ./
    ./file
    ./tar.tar.gz
    (back to karchive builddir)
    bin/ktartest /tmp/tar.tar.gz
    -> ASSERT

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D22786

To: aacid, apol, dfaure
Cc: dfaure, apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190729/99644383/attachment.html>