D22782: KZip::openArchive: Don't assert when opening broken files
David Faure
noreply at phabricator.kde.org
Mon Jul 29 08:42:14 BST 2019
dfaure added a comment.
I disagree. Those errors are for developers, and should therefore be in English (and in qWarning), rather than translated and shown to the user.
A bug report with "Could not seek to file compressed size" translated to Russian or Chinese isn't going to be very useful to most developers, and isn't useful to the user either (compared to tr("Invalid file")).
But this is unrelated to your patch, of course, it's a more fundamental change for this library.
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D22782
To: aacid, dfaure
Cc: dfaure, kde-frameworks-devel, apol, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190729/90b7f4a9/attachment.html>
More information about the Kde-frameworks-devel
mailing list