D22790: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sun Jul 28 23:31:15 BST 2019


apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:29
>  
> +option(BUILD_DESIGNERPLUGIN "Build plugin for Qt Designer" ON)
> +add_feature_info(DESIGNERPLUGIN ${BUILD_DESIGNERPLUGIN} "Build plugin for Qt Designer")

Would it make sense to have this option with the macro? This way we make sure it's easy to disable and we save some boilerplate on every project.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D22790

To: kossebau, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190728/ddccb395/attachment.html>


More information about the Kde-frameworks-devel mailing list