D22723: Fix RunnerManager::queryFinished()

[Fabian Vogt]

fvogt added a comment.


  > QObjects live in their own thread and shouldn't be used outside.
  >  https://doc.qt.io/qt-5/qobject.html#thread
  > 
  > In your patch we are emitting the signal from the run thread instead of the actual object's thread. This is wrong.
  
  Needs a `Qt::QueuedConnection` indeed. Or the job has to be moved to a different thread, which means that Qt makes the connection a queued one automatically.
  
  > Also I'd say there's value in using tools (i.e. Threadweaver) as it's meant to be used, despite you don't liking its semantics.
  
  Yes, improving the Threadweaver API is the best option here.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D22723

To: apol, #frameworks, fvogt, davidedmundson
Cc: aacid, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190727/3c5fc511/attachment.html>