D22764: Stabilize test KFileWidgetTest::testDropFile
Méven Car
noreply at phabricator.kde.org
Fri Jul 26 15:38:29 BST 2019
meven created this revision.
meven added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.
REVISION SUMMARY
The test introduced in D20838 <https://phabricator.kde.org/D20838> was not completely stable.
It causes failures on CI :
https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/139/testReport/junit/projectroot/autotests/kiofilewidgets_kfilewidgettest/
https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.13/job/kio/job/kf5-qt5%20SUSEQt5.13/7/testReport/projectroot/autotests/kiofilewidgets_kfilewidgettest/
This patch replaces a wait by an appropriate QSignalSpy.
TEST PLAN
LANG ctest -R kiofilewidgets
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22764
AFFECTED FILES
autotests/kfilewidgettest.cpp
To: meven, dfaure
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190726/cad8aed6/attachment.html>
More information about the Kde-frameworks-devel
mailing list