D22758: Add a done signal to FindMatchesJob instead of using QObjectDecorator wrongly

[Fabian Vogt]

fvogt created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
fvogt requested review of this revision.

REVISION SUMMARY
  Currently KRunner uses QObjectDecorator wrongly and changing the
  design to fix that would not only be a lot of work, but also include downsides
  like having two custom Job classes, making the code harder to read.
  So merge the part of QObjectDecorator that would've been used here into the
  FindMatchesJob class and drop use of QObjectDecorator.

TEST PLAN
  Added a debug statement in the jobDone slot, it's called.

REPOSITORY
  R308 KRunner

BRANCH
  betterhack

REVISION DETAIL
  https://phabricator.kde.org/D22758

AFFECTED FILES
  src/runnerjobs.cpp
  src/runnerjobs_p.h
  src/runnermanager.cpp

To: fvogt
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190726/a719a21d/attachment.html>