D22755: [platforms/xcb] Use XRES extension to get real window PID
David Edmundson
noreply at phabricator.kde.org
Thu Jul 25 23:48:54 BST 2019
davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
It's increasingly common for apps to be in their own PID namespace. If
this is the case, they report a buggy NET_WM_PID on their windows as
obviously they don't know their own PID.
This patch uses the XResources extension to query the real PID instead
of asking the window.
This allows the task manager to know the real PID when doing lookups for
matching services or showing pulseaudio badges.
Querying the NET_WM_ATOM with the NETWM classes remains unchanged, so we
still have access to all information should a system need it.
BUG: 384837
TEST PLAN
The relevant unit test KWindowInfo::testPid() still passes whilst using
this new extension.
REPOSITORY
R278 KWindowSystem
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22755
AFFECTED FILES
CMakeLists.txt
src/platforms/xcb/CMakeLists.txt
src/platforms/xcb/kwindowinfo.cpp
src/platforms/xcb/kwindowinfo_p_x11.h
To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190725/8354fb9b/attachment.html>
More information about the Kde-frameworks-devel
mailing list