D22699: Support passing target to ecm_qt_declare_logging_category

[Daan De Meyer]

daandemeyer added a comment.


  I

INLINE COMMENTS

> cgiboudeaux wrote in ECMQtDeclareLoggingCategory.cmake:133
> If the change cannot be made compatible with the minimum ECM version, I suggest waiting for KF6.

Personally, I don't see the harm in adding a completely backwards compatible optional feature that requires a higher CMake version (that's already considered very old) but of course it's up to you guys to make the call.

If it is not accepted, can I just leave the revision open until it can be merged for KF6?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D22699

To: daandemeyer, alexmerry
Cc: cgiboudeaux, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190724/4c164123/attachment.html>