D22609: Add spacers as a customization option for toolbars

David Faure noreply at phabricator.kde.org
Sun Jul 21 19:18:28 BST 2019


dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  A video showing the feature, in the merge request! I'm blown away!
  
  Code looks fine.

INLINE COMMENTS

> kxmlguibuilder.cpp:349
> +    } else if (tagName == d->tagSpacer) {
> +        if (KToolBar *bar = qobject_cast<KToolBar *>(parent)) {
> +            // Create the simple spacer widget

(pre-existing, in the separator code above) QToolBar would be sufficient, technically, in this code.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22609

To: felixernst, dfaure
Cc: ngraham, #vdg, dfaure, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190721/305ff0f4/attachment.html>


More information about the Kde-frameworks-devel mailing list