D22586: KRun QML proxy: fix path/URL confusion

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM other than that.

INLINE COMMENTS

> krunproxy.cpp:35
>      QMimeDatabase db;
> -    QMimeType mime = db.mimeTypeForFile(filePath);
> -    const QString fileMymeType = mime.name();
> +    QMimeType mime = db.mimeTypeForFile(fileUrl.isLocalFile() ? fileUrl.toLocalFile() : fileUrl.path());
> +    const QString fileMimeType = mime.name();

would it make sense to use db.mimeTypeForUrl?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22586

To: dfaure, davidedmundson
Cc: apol, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190720/78904326/attachment.html>