D21661: add snoretoast backend for KNotifications on Windows

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> CMakeLists.txt:48
> +   )
> +  find_package(Qt5Network REQUIRED)
> +  list(APPEND knotifications_SRCS notifybysnore.cpp)

find_package calls are usually in the toplevel CMakeLists.txt

> knotification.cpp:382
> +#elif defined(Q_OS_WIN)
> +    return QStringLiteral("win32_defaults");    
> +#else

where is the win32_defaults.notifyrc file?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21661

To: brute4s99, broulik, sredman, vonreth, albertvaka
Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190717/29b71947/attachment.html>