D22488: invoke QIcon::setFallbackThemeName a bit later

Marco Martin noreply at phabricator.kde.org
Tue Jul 16 13:31:23 BST 2019


mart created this revision.
mart added reviewers: Frameworks, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  invoking QIcon::setFallbackThemeName at QCoreApplication ctor
  with Q_COREAPP_STARTUP_FUNCTION breaks the internal status of
  QIconLoader as it instantiates it before the QPlatformTheme,
  but QIconLoader depends from QPlatformTheme to be already instantiated
  otherwise it won't load correctly, thus breaking icon loading
  in QtQuickControls2 styles, such as Material and Fusion
  see https://bugreports.qt.io/browse/QTBUG-74252

TEST PLAN
  icons load correctly in material,
  and the fallback to breeze works with gnome themes

REPOSITORY
  R302 KIconThemes

BRANCH
  phab/qqcicons

REVISION DETAIL
  https://phabricator.kde.org/D22488

AFFECTED FILES
  src/kicontheme.cpp

To: mart, #frameworks, #plasma
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190716/54cebb17/attachment.html>


More information about the Kde-frameworks-devel mailing list