D21660: change audio dep logic wrt win32

Nicolas Fella noreply at phabricator.kde.org
Tue Jul 9 16:38:00 BST 2019


nicolasfella added inline comments.

INLINE COMMENTS

> brute4s99 wrote in CMakeLists.txt:38
> I was trying to simplify code there by removing `NOT`. Should I remove this change?

Yes. It is neither related to Windows nor audio. What you can to is to add Windows to the condition to not look for DBus on Windows, but please do that in a separate patch. Or move the find call for DBus down to the auto checks inside the if

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D21660

To: brute4s99, broulik, nicolasfella
Cc: bcooksley, apol, nicolasfella, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190709/4b3bf424/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list