D22339: Make sure solid backends are reentrant
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Tue Jul 9 14:37:18 BST 2019
apol created this revision.
apol added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
Solid will create different backends for each separate thread but then some backends will use singletons to share some information.
This patch includes measures so this sharing only happens within the same thread or adds the necessary locks so threads respect each other.
TEST PLAN
Tests pass, logic makes sense to me, plasmashell doesn't crash when using D22333 <https://phabricator.kde.org/D22333> (not that it fixes any crashes there)
REPOSITORY
R245 Solid
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D22339
AFFECTED FILES
src/solid/devices/backends/fstab/fstabhandling.cpp
src/solid/devices/backends/hal/halfstabhandling.cpp
src/solid/devices/backends/hal/halstorageaccess.cpp
src/solid/devices/backends/udisks2/udisksdevicebackend.cpp
src/solid/devices/backends/udisks2/udisksdevicebackend.h
src/solid/devices/backends/udisks2/udisksopticaldisc.cpp
src/solid/devices/backends/udisks2/udisksstorageaccess.cpp
To: apol, #frameworks
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190709/bf9f5810/attachment.html>
More information about the Kde-frameworks-devel
mailing list