D22105: WIP : Fix SFTP Plugin of KIO for Windows
Albert Vaca Cintora
noreply at phabricator.kde.org
Fri Jul 5 20:57:45 BST 2019
albertvaka added inline comments.
INLINE COMMENTS
> brute4s99 wrote in kio_sftp.cpp:2257
> yes! thanks Hannah! 🎉
You can keep QT_STAT_LNK on every platform and remove the ifdef. That's the point of the abstraction Qt provides.
For consistency, I would also change the other (S_IFDIR, etc.) to their Qt counterparts.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D22105
To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure
Cc: andriusr, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190705/8bd67f5e/attachment.html>
More information about the Kde-frameworks-devel
mailing list