D22147: Better use of Qt APIs in Plasma::Theme

[Aleix Pol Gonzalez]

apol marked 3 inline comments as done.
apol added inline comments.

INLINE COMMENTS

> fvogt wrote in svg.cpp:317
> It really does not look that way as you're immediately using captures after that.
> 
> If that's really what you want (which I doubt), it should be `sizeHintedKeyExpr.isValid()` instead and be done before the foreach.
> 
> Currently it would just add `QSize(0, 0)` to `elementsWithSizeHints` even for "öoiawze9pv5z2p3v4" as key.

You're right, I looked at the wrong code. Fixed now.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22147

To: apol, #plasma, #frameworks, fvogt
Cc: bruns, tcanabrava, fvogt, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190701/167e498d/attachment.html>