D22147: Better use of Qt APIs in Plasma::Theme

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> apol wrote in svg.cpp:317
> Please note this is only to make sure the regex was properly compiled. It isn't matching there yet.

It really does not look that way as you're immediately using captures after that.

If that's really what you want (which I doubt), it should be `sizeHintedKeyExpr.isValid()` instead and be done before the foreach.

Currently it would just add `QSize(0, 0)` to `elementsWithSizeHints` even for "öoiawze9pv5z2p3v4" as key.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22147

To: apol, #plasma, #frameworks, fvogt
Cc: tcanabrava, fvogt, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190701/13ecb37c/attachment.html>