D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> fstabhandling.cpp:227
> +    QStringList devices = globalFstabCache->m_mtabCache.keys();
> +    const QStringList fstabDevices = globalFstabCache->m_fstabCache.keys();
> +

Don't create a temporary `keys()` list just to iterate it. Use a loop like

  for (auto it = globalFstabCache->m_fstabCache.constBegin(),
       end = globalFstabCache->m_fstabCache.constEnd();
       it != end; ++it) {
      QString deviceName = it.key();
      ...
  }

> fstabhandling.cpp:234
> +        QString deviceName = device;
> +        if (deviceName.endsWith((QLatin1Char('/')))) {
> +            deviceName.chop(1);

Excess parentheses

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D21204

To: meven, bruns, #frameworks
Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n, michaelh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190701/6a3bdab1/attachment.html>