D16894: [ECM] use a macro to add compiler flags conditionally
Christophe Giboudeaux
noreply at phabricator.kde.org
Thu Jan 31 18:53:55 GMT 2019
cgiboudeaux added a comment.
In D16894#402901 <https://phabricator.kde.org/D16894#402901>, @rjvbb wrote:
> > Forget that. The syntax is confusing, please remove this HASFLAG
>
> That I'm not going to do. The goal is to both to have useful feedback like below, and to avoid caching issues that would cause on the first query to be performed (if you were to use a single result variable):
>
> -- Performing Test Clang++_ACCEPTS-Wvla
> ``
So according to you, this line is useful ? from my point of view, it's needless and just looks like a syntax error.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D16894
To: rjvbb, #build_system, kfunk
Cc: cgiboudeaux, dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem, #build_system, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190131/0a677a03/attachment.html>
More information about the Kde-frameworks-devel
mailing list