D18604: Implement support for writing rating information for taglib writer

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> taglibwritertest.cpp:409
> +    QTest::addRow("mp3_0")
> +        << QStringLiteral("mp3")
> +        << QStringLiteral("audio/mpeg3")

What are the differences between the various mp3 test cases?

> taglibwriter.cpp:153
> +        //map the rating values of WMP to Baloo rating
> +        //0->0, 1->2, 25->4, 50->6, 75->8, 99->10
> +        int rating = properties.value(Property::Rating).toInt();

This should probably go into a separate file, togheter with the inverse transform.

This can then be tested independently, i.e.

  for rating in {0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10} {
    r = wmpRating(rating);
    Q_ASSERT(rating = balooRating(r)); }

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18604

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190131/5497a0a6/attachment-0001.html>