D18601: Rewrite taglib writer to use property interface

Stefan BrĂ¼ns noreply at phabricator.kde.org
Thu Jan 31 18:09:19 GMT 2019


bruns added inline comments.

INLINE COMMENTS

> taglibwriter.cpp:123
>  
> -    TagLib::Tag* tags = file.tag();
> +    TagLib::File *file = openFile(&stream, mimeType);
> +    if (!file) {

use a smart pointer (unique_ptr, QScopedPtr) here, and get rid of the delete below.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D18601

To: astippich, bruns, mgallien, broulik, cfeck
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190131/2f34c697/attachment.html>


More information about the Kde-frameworks-devel mailing list