D18317: Display an error message if loading a dictionary fails

[loh tar]

loh.tar added a comment.


  My observations:
  
  - There is no hint when you activate auto spell check (yes, it's out of this scope)
  - Before showing the combobox by "Change Dictionary" the popup appears
  - The combobox shows then some other setting, here it was the first entry
  - When open the config dialog the new popup block the processing. So the expected dialog is only shown after user action
  
  F6576785: 1548859202.png <https://phabricator.kde.org/F6576785>
  
  My suggestion:
  
  - For me are extra popups annoying. I would suggest to avoid them
  - Add some hint embedded to the Sonnet config dialog. IIRC I have seen in some config dialog a similar hint like these KTextEditor::Message, but I may wrong
  - Perhaps should the combobox shown an empty entry or an error hint instead of some (not expected) value
  - How about to emit the full message, not only the missed language? This way is no need to formulate everywhere an own error text
  
  Todo:
  
  - A patch to KTextEditor to show the hint as KTextEditor::Message when some spell check is requested

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D18317

To: ahmadsamir, sandsmark, loh.tar
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190130/45b2991e/attachment-0001.html>