D18599: Use specific error message if file/folder name contains '/'

Nathaniel Graham noreply at phabricator.kde.org
Tue Jan 29 18:06:54 GMT 2019


ngraham added inline comments.

INLINE COMMENTS

> global.h:251
>      ERR_OWNER_DIED = KJob::UserDefinedError + 75, ///< Value used between kuiserver and views when the job owner disappears unexpectedly. It should not be emitted by slaves. @since 5.54
> +    ERR_CANNOT_MKDIR_CONTAINING_SLASH = KJob::UserDefinedError + 76, ///< A specific error for the mkdir job failing due to presence of slashes in the directory names. @since 5.55 
>  };

There's a trailing space here

> job_error.cpp:1083
>          break;
> +        
> +    case ERR_CANNOT_MKDIR_CONTAINING_SLASH:

No spaces on line breaks

> job_error.cpp:1088
> +        solutions << i18n("Do not use slashes in file/folder names.");
> +        break;    
>  

Trailing space

> file.cpp:285
>      const QString path(url.toLocalFile());
> +    
> +#ifndef Q_OS_WIN

No spaces on line breaks

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18599

To: shubham, ngraham, #vdg, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190129/54b27428/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list