D18163: KateRenderer: when printing initially set the color scheme to Printing

[Ahmad Samir]

ahmadsamir added a comment.


  In D18163#398206 <https://phabricator.kde.org/D18163#398206>, @dhaumann wrote:
  
  > Is KateRenderer::setPrinterFriendly() only called in print preview mode? I think not.
  >
  > What is the bahavior currently when you print a page with another schema, and then print a page again? Does it always fallback to Printing without the patch, or does it remember the previous schema?
  
  
  Print -> Options -> Layout, the schema is always remembered with and without the patch.
  
  But I see your point, even though setting the schema in setPrinterFriendly() wouldn't change the behaviour for the File -> Print dialog anyway, it's probably much safer to just set the schema to Printing only in Print Preview and be done with it.
  
  I'll update the diff shortly.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: mwolff, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190129/507257dd/attachment.html>