D18516: Fix end of folding region in rules with lookAhead=true

Dominik Haumann noreply at phabricator.kde.org
Tue Jan 29 03:35:42 GMT 2019


dhaumann added a comment.


  Ok I see: this kind of reverts Christophs changes in the lookahead case.
  
  What I wonder is whether we need a // TODO KF6: add a bool lookAhead in applyFolding() such that we know whether a folding end region should end at 0 or at length.
  
  @cullmann Your take on this? I think it's an improvement, but a comment could be added that states why this differentiation is done.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D18516

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann
Cc: andreasgr, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190129/55d835d5/attachment.html>


More information about the Kde-frameworks-devel mailing list