D18499: [KCM Controls GridView] Add remove animation
Kai Uwe Broulik
noreply at phabricator.kde.org
Thu Jan 24 14:03:08 GMT 2019
broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
This is what all the grid KCMs have been doing, so it makes sense to put it into the component for consistency and maintainability.
It makes for a much nicer user experience when the view has items that can be deleted.
TEST PLAN
Animation looks exactly the same as it did before in the KCMs but allows us to remove 15 lines of boilerplate code from each grid kcm in plasma-desktop
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D18499
AFFECTED FILES
src/qmlcontrols/kcmcontrols/qml/GridView.qml
To: broulik, #plasma, mart
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190124/4c238114/attachment.html>
More information about the Kde-frameworks-devel
mailing list