D11236: [KCrash] Establish socket to allow change of ptracer

[Oswald Buddenhagen]

ossi accepted this revision.
ossi added a comment.
This revision is now accepted and ready to land.


  here too, it should be "ancestor" not "parent" for extra correctness.
  amending the code comment is optional, too.

INLINE COMMENTS

> kcrash.cpp:662
> +        // For now that will be DrKonqi, which may ask to transfer the ptrace scope to
> +        // a debugger using a socket.
>  #ifndef PR_SET_PTRACER

you could make it more specific by saying "a debugger it is not an ancestor of (because it started it via kdeinit or startDetached())"

REPOSITORY
  R285 KCrash

BRANCH
  ptracer

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190124/1f63ff21/attachment.html>