D18487: Reparse background contrast settings when colors changed
Kai Uwe Broulik
noreply at phabricator.kde.org
Wed Jan 23 22:07:10 GMT 2019
broulik added inline comments.
INLINE COMMENTS
> theme_p.cpp:754
> }
> backgroundContrast = cg.readEntry("contrast", _contrast);
> backgroundIntensity = cg.readEntry("intensity", _intensity);
An alternative approach would be to store those values and then do the default fallback and `qGray(color(Plasma::Theme::BackgroundColor).rgb()) < 127` stuff on the fly on demand.
It's runtime cpu cycles vs parsing a config file once on color change (with some awful copy paste)
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D18487
To: broulik, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190123/fec16c4f/attachment.html>
More information about the Kde-frameworks-devel
mailing list