D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

[Albert Astals Cid]

aacid added a comment.


  In D18167#398076 <https://phabricator.kde.org/D18167#398076>, @graesslin wrote:
  
  > The human error exists as long as clang-tidy is not used. What I fear is that someone does a hand porting - we have seen several attempts to do that in KWin from various developers. If devs don't know and now fix the warnings, they can bring in human error.
  
  
  The nice thing about override is that the space for human error is *very* thin, it either compiles and then it's good or it doesn't compile and then it's bad.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18167

To: aacid
Cc: zzag, davidedmundson, kossebau, graesslin, apol, vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190123/8db9e43b/attachment.html>