D18432: Improve contrast of preferences-system-time
Noah Davis
noreply at phabricator.kde.org
Mon Jan 21 17:44:38 GMT 2019
ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.
Make the outline a solid circle behind the clock part instead of just an outline. The reason for this is that the edges between the outline and the clock look worse if the outline isn't a solid circle in the background. Notice how the left side has rougher edges: F6560806: Screenshot_20190121_123932.png <https://phabricator.kde.org/F6560806>
In general, it's a good idea to not make 2 shapes meet exactly at the edges due to issues with how SVGs are displayed. This isn't an Inkscape only either. It doesn't always need to be done that way, but it's especially necessary with shapes that have round edges.
I think it might be a good idea to make it look more like a clock, but I'm not going to object to keeping the current look.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D18432
To: trickyricky26, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190121/fe555569/attachment.html>
More information about the Kde-frameworks-devel
mailing list