D18425: [KUrlNavigatorPlacesSelector] Properly identify teardown action
Kai Uwe Broulik
noreply at phabricator.kde.org
Mon Jan 21 09:48:36 GMT 2019
broulik created this revision.
broulik added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
Rather than relying on the model count (which broke when we added places categories), just identify the action by the data it is given.
BUG: 403454
TEST PLAN
- Hid Places panel in Dolphin and navigated around some mounts: Only one Unmount entry that came and went as it should
- Unmount still works
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D18425
AFFECTED FILES
src/filewidgets/kurlnavigatorplacesselector.cpp
To: broulik, #frameworks, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190121/942a04f3/attachment.html>
More information about the Kde-frameworks-devel
mailing list