D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

[Albert Astals Cid]

aacid added a comment.


  In D18167#397020 <https://phabricator.kde.org/D18167#397020>, @graesslin wrote:
  
  > This causes in KWin 500+ new warnings. Do you really think it's a good idea to spam all of KDE with new compiler warnings. KDE has an old code base. We cannot enable warnings for the way you developed C++ for 20 years.
  
  
  These warnings are a good, thing, it's too easy to break an interface and never realize if you did not mark your functions as override.
  
  Anyway, if you don't want the warnings just disable them for gcc, you already made the decision to disable it for clang, so just extend it to gcc.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D18167

To: aacid
Cc: graesslin, apol, vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20190120/0de5038f/attachment.html>